Re: [PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding style issues

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding style issues
Date	2017-02-17 19:50 +0100
Message-ID	<tbVLs-7V6-7@gated-at.bofh.it> (permalink)
References	<tbVLs-7V6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Feb 17, 2017 at 01:39:07PM -0500, Nathan Howard wrote:
> The following coding style issues (as per checkpatch.pl) were resolved.
> 
> WARNING: Block comments use * on subsequent lines
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
> WARNING: Missing a blank line after declarations
> WARNING: Use of volatile is usually wrong:...
> WARNING: line over 80 characters
> CHECK: Concatenated strings should use spaces between elements
> CHECK: Macro argument 'vol' may be better as '(vol)' to avoid precedence issues

Please only do one thing per patch, and no, "fix style issues" is not
one thing :(

This should be a patch series, one per type of thing done.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: bcm2835-audio: bcm2835.h: fix various coding  style issues Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-17 19:50 +0100

csiph-web