Re: [PATCH 2/2] f2fs: fix the case when there is no free segment to allocate for CURSEG_WARM_NODE

From	Jaegeuk Kim <jaegeuk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] f2fs: fix the case when there is no free segment to allocate for CURSEG_WARM_NODE
Date	2017-02-17 19:40 +0100
Message-ID	<tbVBM-7Rv-19@gated-at.bofh.it> (permalink)
References	<tbQ93-4lj-11@gated-at.bofh.it> <tbQ93-4lj-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Yunlong,

I already started to test this since a couple of days ago. :)

http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=908b5f463c82eaf972b149a26bb310f5e25064fd

Thanks,

On 02/17, Yunlong Song wrote:
> If the free segments are used up, then new_curseg will fail for
> CURSEG_WARM_NODE, in this case, we should use change_curseg instead of
> new_curseg.
> 
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
>  fs/f2fs/segment.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index df2ff5c..32820cd 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1564,8 +1564,6 @@ static void allocate_segment_by_default(struct f2fs_sb_info *sbi,
>  
>  	if (force)
>  		new_curseg(sbi, type, true);
> -	else if (type == CURSEG_WARM_NODE)
> -		new_curseg(sbi, type, false);
>  	else if (curseg->alloc_type == LFS && is_next_segment_free(sbi, type))
>  		new_curseg(sbi, type, false);
>  	else if (need_SSR(sbi) && get_ssr_segment(sbi, type))
> -- 
> 1.8.5.2

Thread

[PATCH 2/2] f2fs: fix the case when there is no free segment to allocate for CURSEG_WARM_NODE Yunlong Song <yunlong.song@huawei.com> - 2017-02-17 13:50 +0100
  Re: [PATCH 2/2] f2fs: fix the case when there is no free segment to  allocate for CURSEG_WARM_NODE Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-17 19:40 +0100
    Re: [PATCH 2/2] f2fs: fix the case when there is no free segment to  allocate for CURSEG_WARM_NODE Chao Yu <yuchao0@huawei.com> - 2017-02-23 13:10 +0100
      Re: [PATCH 2/2] f2fs: fix the case when there is no free segment to  allocate for CURSEG_WARM_NODE Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-23 20:30 +0100

csiph-web