Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583445
| From | Alexander Shishkin <alexander.shishkin@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end |
| Date | 2017-02-17 15:20 +0100 |
| Message-ID | <tbRya-5mq-23@gated-at.bofh.it> (permalink) |
| References | <t4j8d-7uS-11@gated-at.bofh.it> <t4j8d-7uS-17@gated-at.bofh.it> <tbR57-4Vq-15@gated-at.bofh.it> <tbRou-5iA-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Will Deacon <will.deacon@arm.com> writes: > On Fri, Feb 17, 2017 at 03:40:23PM +0200, Alexander Shishkin wrote: >> Will Deacon <will.deacon@arm.com> writes: >> >> > @@ -485,7 +485,8 @@ int intel_bts_interrupt(void) >> > return handled; >> > >> > perf_aux_output_end(&bts->handle, local_xchg(&buf->data_size, 0), >> > - !!local_xchg(&buf->lost, 0)); >> > + local_xchg(&buf->lost, 0) ? >> > + PERF_AUX_FLAG_OVERWRITE : 0); >> >> Heh, this one would have taken some time to debug. :) > > Don't worry, this isn't a bug fix! This patch changes the prototype for > perf_aux_output_end so that it takes the flag instead of a "bool truncated" > parameter, so this is just fixing up the callers at the same time. Yeah, I got that, what I'm saying is that the above should be PERF_AUX_FLAG_TRUNCATED, not OVERWRITE. I only spotted it by accident. Regards, -- Alex
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-02-17 14:50 +0100
Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Will Deacon <will.deacon@arm.com> - 2017-02-17 15:10 +0100
Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-02-17 15:20 +0100
Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Will Deacon <will.deacon@arm.com> - 2017-02-17 15:50 +0100
Re: [PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2017-02-17 16:10 +0100
csiph-web