Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583215
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins |
| Date | 2017-02-17 09:50 +0100 |
| Message-ID | <tbMoO-1Y8-21@gated-at.bofh.it> (permalink) |
| References | <tbtPb-6h4-3@gated-at.bofh.it> <tbtPd-6h4-55@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Feb 16, 2017 at 01:48:46PM +0100, Corentin Labbe wrote:
> This patch add pinctrl node for dwmac-sun8i on H3.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 61d56d2..59ed40e 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -349,6 +349,17 @@
> function = "i2c2";
> };
>
> + emac_rgmii_pins: emac0@0 {
> + allwinner,pins = "PD0", "PD1", "PD2", "PD3",
> + "PD4", "PD5", "PD7",
> + "PD8", "PD9", "PD10",
> + "PD12", "PD13", "PD15",
> + "PD16", "PD17";
> + allwinner,function = "emac";
Please use the generic pin config properties (ie. pins and functions).
> + allwinner,drive = <SUN4I_PINCTRL_40_MA>;
Why do you need to use 40mA?
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
This is the default now.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-16 14:00 +0100
Re: [PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-17 09:50 +0100
Re: [PATCH 08/21] ARM: dts: sun8i-h3: add dwmac-sun8i rgmii pins Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-17 10:20 +0100
csiph-web