[PATCH v3 1/7] dell-led: remove GUID check from dell_micmute_led_set()

From	Michał Kępień <kernel@kempniu.pl>
Newsgroups	linux.kernel
Subject	[PATCH v3 1/7] dell-led: remove GUID check from dell_micmute_led_set()
Date	2017-02-17 09:00 +0100
Message-ID	<tbLCq-1kS-39@gated-at.bofh.it> (permalink)
References	<tbLCp-1kS-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

As dell_micmute_led_set() no longer uses the dell_wmi_perform_query()
method, which was removed in commit 0c41a08e131d ("dell-led: use
dell_smbios_send_request() for performing SMBIOS calls"), the
DELL_APP_GUID check is redundant and thus can be safely removed.

Signed-off-by: Michał Kępień <kernel@kempniu.pl>
Tested-by: Alex Hung <alex.hung@canonical.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
---
 drivers/leds/dell-led.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/leds/dell-led.c b/drivers/leds/dell-led.c
index b3d6e9c15cf9..e8e8f67224c1 100644
--- a/drivers/leds/dell-led.c
+++ b/drivers/leds/dell-led.c
@@ -51,9 +51,6 @@ static int dell_micmute_led_set(int state)
 	struct calling_interface_buffer *buffer;
 	struct calling_interface_token *token;
 
-	if (!wmi_has_guid(DELL_APP_GUID))
-		return -ENODEV;
-
 	if (state == 0)
 		token = dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE);
 	else if (state == 1)
-- 
2.11.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v3 1/7] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień <kernel@kempniu.pl> - 2017-02-17 09:00 +0100

csiph-web