Re: [BUG] 4.10-rc8 - ping spinning?

From	Soheil Hassas Yeganeh <soheil@google.com>
Newsgroups	linux.kernel
Subject	Re: [BUG] 4.10-rc8 - ping spinning?
Date	2017-02-17 05:30 +0100
Message-ID	<tbIlc-7KL-11@gated-at.bofh.it> (permalink)
References	<tbt2O-5ZY-15@gated-at.bofh.it> <tbwDn-8mJ-5@gated-at.bofh.it> <tbwDn-8mJ-3@gated-at.bofh.it> <tbwN3-fF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 16, 2017 at 11:08 AM,  <lkml@pengaru.com> wrote:
> On Thu, Feb 16, 2017 at 10:52:19AM -0500, Soheil Hassas Yeganeh wrote:
>> On Thu, Feb 16, 2017 at 10:50 AM, Soheil Hassas Yeganeh
>> <soheil@google.com> wrote:
>> > Thank you Vito for the report.
>> >
>> > The patch you cited actually resolves a similar backward compatibility
>> > problem for traceroute.
>> >
>> > I suspect the problem here is that there's a local error queued on the
>> > error queue after an ICMP message. ping apparently expect the
>> > sk->sk_err to be set for the local errors as well, and hence the
>> > error. Ideally, ping should read the error queue if there an EPOLLERR,
>> > because local errors never sk->sk_err on their own. That is, if we
>> > have
>>
>> [oops] That is, if we have only one local error on the error queue, we
>> cannot rely on having an error on recvmsg (i.e., sk->sk_err being set)
>> even in 4.9.
>>
>> <snip>
>
> Hi Soheil,
>
> This doesn't appear to be trivially reproducible here by just running ping
> as it were originally discovered.  I'll see if I can reliably cause the
> malfunction somehow, but until then I can't meaningfully test patches.
>
> Perhaps a form of fault injection would make more sense if there's a
> reasonable idea of what this is stemming from?

I tried to generate different ICMP errors as well as local errors, but
unfortunately haven't been able to reproduce the problem.

> I've opened an issue with iputils on github in the event that this is found
> to be a ping bug.  Your input might be helpful there as well:
> https://github.com/iputils/iputils/issues/74

Sent a pull request. Although, we might want to at least confirm the
userspace patch fixes the issue in ping.

Thanks!
Soheil

> Thanks,
> Vito Caputo

Thread

Re: [BUG] 4.10-rc8 - ping spinning? lkml@pengaru.com - 2017-02-16 13:10 +0100
  Re: [BUG] 4.10-rc8 - ping spinning? Soheil Hassas Yeganeh <soheil@google.com> - 2017-02-16 17:00 +0100
    Re: [BUG] 4.10-rc8 - ping spinning? lkml@pengaru.com - 2017-02-16 17:10 +0100
      Re: [BUG] 4.10-rc8 - ping spinning? Soheil Hassas Yeganeh <soheil@google.com> - 2017-02-17 05:30 +0100
  Re: [BUG] 4.10-rc8 - ping spinning? Soheil Hassas Yeganeh <soheil@google.com> - 2017-02-16 17:00 +0100

csiph-web