Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583053

[PATCH 1/7] drm/sun4i: Move drm_mode_config_cleanup call to main driver

Show all headers | View raw

drm_mode_config_cleanup is the complement of drm_mode_config_init, which
is called in the bind function of sun4i_drv. drm_mode_config_cleanup
should be put in the unbind function to match.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/gpu/drm/sun4i/sun4i_drv.c         | 1 +
 drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 4ce665349f6b..99a0f1861be2 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -188,6 +188,7 @@ static void sun4i_drv_unbind(struct device *dev)
 	drm_dev_unregister(drm);
 	drm_kms_helper_poll_fini(drm);
 	sun4i_framebuffer_free(drm);
+	drm_mode_config_cleanup(drm);
 	drm_vblank_cleanup(drm);
 	drm_dev_unref(drm);
 }
diff --git a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
index 8b6ce619ad81..0c72b54c047d 100644
--- a/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
+++ b/drivers/gpu/drm/sun4i/sun4i_framebuffer.c
@@ -50,5 +50,4 @@ void sun4i_framebuffer_free(struct drm_device *drm)
 	struct sun4i_drv *drv = drm->dev_private;
 
 	drm_fbdev_cma_fini(drv->fbdev);
-	drm_mode_config_cleanup(drm);
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] drm/sun4i: Various fixes and cleanups part 1 Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
  [PATCH 4/7] drm/sun4i: Fix kcalloc element size in sun4i_layers_init Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
    Re: [PATCH 4/7] drm/sun4i: Fix kcalloc element size in  sun4i_layers_init Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-21 23:20 +0100
  [PATCH 1/7] drm/sun4i: Move drm_mode_config_cleanup call to main driver Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
    Re: [PATCH 1/7] drm/sun4i: Move drm_mode_config_cleanup call to main  driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-21 21:30 +0100
  [PATCH 5/7] drm/sun4i: Drop useless assignment in sun4i_layers_init Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
    Re: [PATCH 5/7] drm/sun4i: Drop useless assignment in  sun4i_layers_init Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-21 23:20 +0100
  [PATCH 3/7] drm/sun4i: Check return value of drm_vblank_init Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
    Re: [PATCH 3/7] drm/sun4i: Check return value of drm_vblank_init Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-21 23:20 +0100
  [PATCH 6/7] drm/sun4i: Save newly created layer in layers array in sun4i_layers_init Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
    Re: [PATCH 6/7] drm/sun4i: Save newly created layer in layers array  in sun4i_layers_init Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-21 23:20 +0100
  [PATCH 7/7] drm/sun4i: Make sun4i_crtc_init return ERR_PTR style error codes Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
    Re: [PATCH 7/7] drm/sun4i: Make sun4i_crtc_init return ERR_PTR style  error codes Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-21 23:20 +0100
  [PATCH 2/7] drm/sun4i: Fix up error path cleanup for master bind function Chen-Yu Tsai <wens@csie.org> - 2017-02-17 04:20 +0100
    Re: [PATCH 2/7] drm/sun4i: Fix up error path cleanup for master bind  function Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-21 21:30 +0100

csiph-web