Re: [PATCH] remoteproc: qcom: mdt_loader: Use signed type for offset

From	Andy Gross <andy.gross@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] remoteproc: qcom: mdt_loader: Use signed type for offset
Date	2017-02-17 01:40 +0100
Message-ID	<tbEKB-5qy-9@gated-at.bofh.it> (permalink)
References	<tbngJ-1OH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 15, 2017 at 02:00:41PM -0800, Bjorn Andersson wrote:
> In the transition from using rproc_da_to_va(), the type of the load
> offset became unsigned. This causes the subsequent check to let negative
> values less than p_memsz + mem_size through and we write outside of the
> buffer.
> 
> Change the type back to a signed value to catch this.
> 
> Fixes: 7f0dd07a9b29 ("remoteproc: qcom: mdt_loader: Refactor MDT loader")
> Fixes: e7fd25226295 ("remoteproc: qcom: q6v5: Decouple driver from MDT loader")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Acked-by: Andy Gross <andy.gross@linaro.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] remoteproc: qcom: mdt_loader: Use signed type for offset Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-02-16 07:00 +0100
  Re: [PATCH] remoteproc: qcom: mdt_loader: Use signed type for offset Andy Gross <andy.gross@linaro.org> - 2017-02-17 01:40 +0100

csiph-web