Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1582961

[PATCH] Input: fix ptr_ret.cocci warnings

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From kbuild test robot <lkp@intel.com>
Newsgroups linux.kernel
Subject [PATCH] Input: fix ptr_ret.cocci warnings
Date Thu, 16 Feb 2017 22:50:01 +0100
Message-ID <tbC65-3M4-7@gated-at.bofh.it> (permalink)
References <tbC65-3M4-5@gated-at.bofh.it> <tbyvy-1iO-69@gated-at.bofh.it>
X-Extloop1 1
X-Ironport-Av E=Sophos;i="5.35,169,1484035200"; d="scan'208";a="1109436697"
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP <locally generated>
X-Sa-Exim-Mail-From fengguang.wu@intel.com
X-Sa-Exim-Scanned No (on bee); SAEximRunCond expanded to false
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
Organization linux.* mail to news gateway
X-Original-Cc kbuild-all@01.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Andrew Duggan <aduggan@synaptics.com>, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
X-Original-Date Fri, 17 Feb 2017 05:44:46 +0800
X-Original-Message-ID <20170216214443.GA93630@lkp-ib04.lkp.intel.com>
X-Original-References <201702170545.UnYJQAQK%fengguang.wu@intel.com> <20170216175100.1668-3-benjamin.tissoires@redhat.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1582961

Show key headers only | View raw


drivers/input/mouse/synaptics.c:279:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

CC: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 synaptics.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -276,10 +276,7 @@ static int synaptics_create_intertouch(s
 	pdevinfo.parent = &psmouse->ps2dev.serio->dev;
 
 	pdev = platform_device_register_full(&pdevinfo);
-	if (IS_ERR(pdev))
-		return PTR_ERR(pdev);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(pdev);
 }
 
 static int synaptics_remove_intertouch_device(struct device *dev, void *data)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/3] Bind RMI4 over SMBus from PS/2 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-02-16 19:00 +0100
  [PATCH v2 2/3] Input: synaptics - allocate a Synaptics Intertouch device Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-02-16 19:00 +0100
    Re: [PATCH v2 2/3] Input: synaptics - allocate a Synaptics  Intertouch device kbuild test robot <lkp@intel.com> - 2017-02-16 22:50 +0100
    [PATCH] Input: fix ptr_ret.cocci warnings kbuild test robot <lkp@intel.com> - 2017-02-16 22:50 +0100
  [PATCH v2 4/3] Input: ps2smbus - force PS/2 disable before SMBus gets resumed Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-02-17 12:50 +0100

csiph-web