Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582919

[tip:perf/core] perf tools: Add missing parse_events_error() prototype

Show all headers | View raw

Commit-ID:  34a0548f01626b01c9e98d9627812c3c9f6b6f7d
Gitweb:     http://git.kernel.org/tip/34a0548f01626b01c9e98d9627812c3c9f6b6f7d
Author:     Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Wed, 15 Feb 2017 10:09:11 -0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 15 Feb 2017 11:20:49 -0300

perf tools: Add missing parse_events_error() prototype

As pointed out by clang, we were not providing a prototype for a
function before using it:

  util/parse-events.y:699:6: error: conflicting types for 'parse_events_error'
  void parse_events_error(YYLTYPE *loc, void *data,
       ^
  /tmp/build/perf/util/parse-events-bison.c:2224:7: note: previous implicit declaration is here
        yyerror (&yylloc, _data, scanner, YY_("syntax error"));
        ^
  /tmp/build/perf/util/parse-events-bison.c:65:25: note: expanded from macro 'yyerror'
  #define yyerror         parse_events_error

  1 error generated.

One line fix it.

Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20170215130605.GC4020@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/parse-events.y | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
index 3a51963..a14b47a 100644
--- a/tools/perf/util/parse-events.y
+++ b/tools/perf/util/parse-events.y
@@ -17,6 +17,8 @@
 #include "parse-events.h"
 #include "parse-events-bison.h"
 
+void parse_events_error(YYLTYPE *loc, void *data, void *scanner, char const *msg);
+
 #define ABORT_ON(val) \
 do { \
 	if (val) \

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

perf pmu: clang points out: address of array 'alias->unit' will  always evaluate to 'true' Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-14 19:30 +0100
  Re: perf pmu: clang points out: address of array 'alias->unit' will  always evaluate to 'true' Jiri Olsa <jolsa@redhat.com> - 2017-02-15 12:00 +0100
    perf bison: clang points out: error: conflicting types for  'parse_events_error' always evaluate to 'true' Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-15 13:50 +0100
      Re: perf bison: clang points out: error: conflicting types for  'parse_events_error' always evaluate to 'true' Jiri Olsa <jolsa@redhat.com> - 2017-02-15 14:00 +0100
        perf build with clang, modulo libpython: Re: perf bison: clang  points out: error: conflicting types for 'parse_events_error' always  evaluate to 'true' Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-15 14:10 +0100
          Re: perf build with clang, modulo libpython: Re: perf bison: clang  points out: error: conflicting types for 'parse_events_error' always  evaluate to 'true' Jiri Olsa <jolsa@redhat.com> - 2017-02-15 14:30 +0100
          [tip:perf/core] perf tools: Add missing parse_events_error()  prototype tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com> - 2017-02-16 21:10 +0100
  [tip:perf/core] perf pmu: Fix check for unset alias->unit array tip-bot for Arnaldo Carvalho de Melo <tipbot@zytor.com> - 2017-02-16 21:10 +0100

csiph-web