Re: [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for Altera FPGAs

From	Anatolij Gustschin <agust@denx.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for Altera FPGAs
Date	2017-02-15 16:30 +0100
Message-ID	<tb9GO-1II-25@gated-at.bofh.it> (permalink)
References	<t3hLb-1N5-7@gated-at.bofh.it> <t3hLc-1N5-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Joshua,

On Tue, 24 Jan 2017 14:19:33 -0800
Joshua Clayton stillcompiling@gmail.com wrote:
...
>+static int cyclonespi_write(struct fpga_manager *mgr, const char *buf,
>+			    size_t count)
>+{
>+	struct cyclonespi_conf *conf = (struct cyclonespi_conf *)mgr->priv;
>+	const char *fw_data = buf;
>+	const char *fw_data_end = fw_data + count;
>+
>+	while (fw_data < fw_data_end) {
>+		int ret;
>+		size_t stride = min(fw_data_end - fw_data, SZ_4K);
>+
>+		rev_buf(fw_data, stride);

Can we make rev_buf() optional here? I've tested this driver with
Stratix-V FPGA using orion_spi driver. It works without swapping
the data.

Thanks,
Anatolij

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for  Altera FPGAs Anatolij Gustschin <agust@denx.de> - 2017-02-15 16:30 +0100
  Re: [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for Altera FPGAs Alan Tull <delicious.quinoa@gmail.com> - 2017-02-15 18:20 +0100
    Re: [PATCH v9 2/3] fpga manager: Add cyclone-ps-spi driver for Altera  FPGAs Joshua Clayton <stillcompiling@gmail.com> - 2017-02-16 00:10 +0100

csiph-web