Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1581398

Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible

Show all headers | View raw

On 15/02/17 13:44, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@ti.com> writes:
>> To avoid checkpatch warnings with new patches let's
>> start using the BIT() macro wherever possible.
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>  drivers/usb/dwc3/core.h      | 192 +++++++++++++++++++++----------------------
>>  drivers/usb/dwc3/dwc3-omap.c |  48 +++++------
>>  drivers/usb/dwc3/gadget.h    |  20 ++---
>>  3 files changed, 130 insertions(+), 130 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index 14b7602..d514dca 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -65,7 +65,7 @@
>>  #define DWC3_DEVICE_EVENT_OVERFLOW		11
>>  
>>  #define DWC3_GEVNTCOUNT_MASK	0xfffc
>> -#define DWC3_GEVNTCOUNT_EHB	(1 << 31)
>> +#define DWC3_GEVNTCOUNT_EHB	BIT(31)
> 
> don't you need to include <linux/bitops.h> for this?
> 

I didn't get any build errors though.

-- 
cheers,
-roger

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] usb: dwc3: use BIT() macro where possible Roger Quadros <rogerq@ti.com> - 2017-02-15 12:40 +0100
  Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible Felipe Balbi <balbi@kernel.org> - 2017-02-15 12:50 +0100
    Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible Roger Quadros <rogerq@ti.com> - 2017-02-15 16:30 +0100
      Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible Felipe Balbi <balbi@kernel.org> - 2017-02-16 10:00 +0100
        Re: [PATCH 2/3] usb: dwc3: use BIT() macro where possible Roger Quadros <rogerq@ti.com> - 2017-02-16 11:40 +0100
  [PATCH v2 2/3] usb: dwc3: use BIT() macro where possible Roger Quadros <rogerq@ti.com> - 2017-02-16 12:10 +0100

csiph-web