Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1581351

Re: [Suggestion/Problems] perf annoate: Some problems related to the source code view and Improvement of it with line numbers

Show all headers | View raw

On 02/15/2017 10:24 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Feb 15, 2017 at 09:34:51PM +0900, Taeung Song escreveu:
>> > Hi all :)
>> >
>> > I found some problems about showing line numbers of perf-annotate.
>> > and I have a suggestion about perf-annotate.
>> >
>> > Sure, I have a plan to send the patchset about that.
>> > But I'd like to know other opinions about that before sending the patchset.
>> > :)
> Humm, TLDR, please try to find one problem, describe it precisely, show
> before and after results (in the changeset message), and send it, rinse,
> repeat.
>
> For instance, if the line numbers are different in --stdio and --tui,
> that is a problem, state that, show the output (as you did below), put
> it in a patch, send it.
>

Okey it was too long.

I'll separate the contents into simple parts
and send a patch with things you said :)
for easy review.

Thanks,
Taeung

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Suggestion/Problems] perf annoate: Some problems related to the  source code view and Improvement of it with line numbers Taeung Song <treeze.taeung@gmail.com> - 2017-02-15 13:40 +0100
  Re: [Suggestion/Problems] perf annoate: Some problems related to the  source code view and Improvement of it with line numbers Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-15 14:30 +0100
    Re: [Suggestion/Problems] perf annoate: Some problems related to the  source code view and Improvement of it with line numbers Taeung Song <treeze.taeung@gmail.com> - 2017-02-15 15:30 +0100
      Re: [Suggestion/Problems] perf annoate: Some problems related to the  source code view and Improvement of it with line numbers Taeung Song <treeze.taeung@gmail.com> - 2017-02-17 03:40 +0100
        Re: [Suggestion/Problems] perf annoate: Some problems related to the  source code view and Improvement of it with line numbers Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-17 14:40 +0100
          Re: [Suggestion/Problems] perf annoate: Some problems related to the  source code view and Improvement of it with line numbers Taeung Song <treeze.taeung@gmail.com> - 2017-02-18 01:20 +0100

csiph-web