Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1581241

Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl_task()

Show all headers | View raw

On Wed, Feb 15, 2017 at 10:47:49AM +0000, Juri Lelli wrote:
> [+Steve, Luca]
> 
> Hi,
> 
> On 15/02/17 14:11, Byungchul Park wrote:
> > Once pick_next_pushable_dl_task(rq) return a task, it guarantees that
> > the task's cpu is rq->cpu, so task_cpu(next_task) is always rq->cpu if
> > task == next_task. Remove a redundant condition and make code simpler.
> > 
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > ---
> >  kernel/sched/deadline.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index 27737f3..ad8d577 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -1483,7 +1483,7 @@ static int push_dl_task(struct rq *rq)
> >  		 * then possible that next_task has migrated.
> >  		 */
> >  		task = pick_next_pushable_dl_task(rq);
> > -		if (task_cpu(next_task) == rq->cpu && task == next_task) {
> > +		if (task == next_task) {
> 
> Seems a sensible optimization to me. Actually, we are doing the same for
> rt.c; Steve, Peter, do you think we should optimize that as well?
> 

If correct (and I've not spend brain cycles on that) yes. We should keep
this push-pull muck synced between rt and deadline as much as possible.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sched/deadline: Remove unnecessary condition in push_dl_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-15 06:20 +0100
  Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-15 06:30 +0100
  Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Juri Lelli <juri.lelli@arm.com> - 2017-02-15 11:50 +0100
    Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Peter Zijlstra <peterz@infradead.org> - 2017-02-15 12:40 +0100
    Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Steven Rostedt <rostedt@goodmis.org> - 2017-02-15 15:30 +0100
      Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Juri Lelli <juri.lelli@arm.com> - 2017-02-15 15:50 +0100
        Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Steven Rostedt <rostedt@goodmis.org> - 2017-02-15 16:00 +0100
        Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-16 03:20 +0100
          Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Steven Rostedt <rostedt@goodmis.org> - 2017-02-16 03:40 +0100
            Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Steven Rostedt <rostedt@goodmis.org> - 2017-02-16 03:40 +0100
              Re: [PATCH] sched/deadline: Remove unnecessary condition in  push_dl_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-16 03:50 +0100

csiph-web