[PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

From	Roger Quadros <rogerq@ti.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()
Date	2017-02-15 12:40 +0100
Message-ID	<tb66d-7Lf-1@gated-at.bofh.it> (permalink)
References	<tb66d-7Lf-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

We need to break from all cases if we want to treat
each one of them separately.

Reported-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently")
Cc: <stable@vger.kernel.org> #v4.8+
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/usb/dwc3/dwc3-omap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index eb1b9cb..35b6351 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -250,6 +250,7 @@ static void dwc3_omap_set_mailbox(struct dwc3_omap *omap,
 		val = dwc3_omap_read_utmi_ctrl(omap);
 		val |= USBOTGSS_UTMI_OTG_CTRL_IDDIG;
 		dwc3_omap_write_utmi_ctrl(omap, val);
+		break;
 
 	case OMAP_DWC3_VBUS_OFF:
 		val = dwc3_omap_read_utmi_ctrl(omap);
-- 
2.7.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/3] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() Roger Quadros <rogerq@ti.com> - 2017-02-15 12:40 +0100

csiph-web