Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581149

Re: rt2500usb: don't mark register accesses as inline

From Kalle Valo <kvalo@codeaurora.org>
Newsgroups linux.kernel
Subject Re: rt2500usb: don't mark register accesses as inline
Date 2017-02-15 10:20 +0100
Message-ID <tb3UJ-6uh-9@gated-at.bofh.it> (permalink)
References <taSPE-72f-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Arnd Bergmann <arnd@arndb.de> wrote:
> When CONFIG_KASAN is set, we get a rather large stack here:
> 
> drivers/net/wireless/ralink/rt2x00/rt2500usb.c: In function 'rt2500usb_set_device_state':
> drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1074:1: error: the frame size of 3032 bytes is larger than 100 bytes [-Werror=frame-larger-than=]
> 
> If we don't force those functions to be inline, the compiler can figure this
> out better itself and not inline the functions when doing so would be harmful,
> reducing the stack size to a merge 256 bytes.
> 
> Note that there is another problem that manifests in this driver, as a result
> of the typecheck() macro causing even larger stack frames.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied to wireless-drivers-next.git, thanks.

727241660912 rt2500usb: don't mark register accesses as inline

-- 
https://patchwork.kernel.org/patch/9572947/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] rt2500usb: don't mark register accesses as inline Arnd Bergmann <arnd@arndb.de> - 2017-02-14 22:30 +0100
  Re: [PATCH] rt2500usb: don't mark register accesses as inline Kalle Valo <kvalo@codeaurora.org> - 2017-02-15 07:00 +0100
    Re: [PATCH] rt2500usb: don't mark register accesses as inline Arnd Bergmann <arnd@arndb.de> - 2017-02-15 08:50 +0100
  Re: rt2500usb: don't mark register accesses as inline Kalle Valo <kvalo@codeaurora.org> - 2017-02-15 10:20 +0100

csiph-web