Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values

From	Djalal Harouni <tixxdz@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values
Date	2017-02-15 10:00 +0100
Message-ID	<tb3Bn-678-11@gated-at.bofh.it> (permalink)
References	<t0fwd-WM-7@gated-at.bofh.it> <t0fwe-WM-27@gated-at.bofh.it> <tax8u-1hI-3@gated-at.bofh.it> <taVNv-wP-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 15, 2017 at 1:34 AM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Mon, 13 Feb 2017 14:16:30 -0800 Kees Cook <keescook@chromium.org> wrote:
>
>> On Mon, Jan 16, 2017 at 5:23 AM, Djalal Harouni <tixxdz@gmail.com> wrote:
>> > From: Lafcadio Wluiki <wluikil@gmail.com>
>> >
>> > Previously, the hidepid parameter was checked by comparing literal
>> > integers 0, 1, 2. Let's add a proper enum for this, to make the checking
>> > more expressive:
>> >
>> >         0 ___ HIDEPID_OFF
>> >         1 ___ HIDEPID_NO_ACCESS
>> >         2 ___ HIDEPID_INVISIBLE
>> >
>> > This changes the internal labelling only, the userspace-facing interface
>> > remains unmodified, and still works with literal integers 0, 1, 2.
>> >
>> > No functional changes.
>> >
>> > Acked-by: Kees Cook <keescook@chromium.org>
>> > Acked-by: Djalal Harouni <tixxdz@gmail.com>
>> > Signed-off-by: Lafcadio Wluiki <wluikil@gmail.com>
>>
>> Andrew, can you take this? It's a sensible cleanup to drop literals in
>> favor of defines.
>
> Sure.
>
> Djalal, I converted your acked-by into a signed-off-by, as described in
> Documentation/SubmittingPatches (soon to become
> Documentation/process/submitting-patches.rst).

Thank you Andrew!

-- 
tixxdz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values Kees Cook <keescook@chromium.org> - 2017-02-13 23:20 +0100
  Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values Andrew Morton <akpm@linux-foundation.org> - 2017-02-15 01:40 +0100
    Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values Djalal Harouni <tixxdz@gmail.com> - 2017-02-15 10:00 +0100

csiph-web