Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580156
| Path | csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!fu-berlin.de!bofh.it!news.nic.it!robomod |
|---|---|
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] Input: tca8418_keypad - remove double read of key event register |
| Date | Tue, 14 Feb 2017 01:00:02 +0100 |
| Message-ID | <tayHg-2e2-7@gated-at.bofh.it> (permalink) |
| X-Original-To | linux-input@vger.kernel.org |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=ZU4vs3uYXNNeg/ZoifC7SKCI1QmuNrGIaaaLcVGgTyo=; b=EDi8iKaMgh4RbNE0vSPOF0zmm+wGiuWYl1k4YEprsgvOtUHXSz4AeoyiKDcHczIzkU XLmA2G08REkYuN1MJN8M5wOWcm5j/VaCBebsVLjI+McMn+HM7lhU8pEHULU28si734Np ez/RtxsPXPSk15wmrf89BrV9ugKN82meC8dEWPKAn4h3LKNuxP9qO2xidaLFefpT/qC8 L1RJbsHzDlozPyj9smwoyV6yIvKZRCgfBaWkumc39r5uIPQ3F6TwUyP6Xw49ActjePGI x1gq8J6UXdUsOlNoj8W625+s+vlUmM+YsS0z2IETfm0ZePb8QHGKh3f0YyGjA8WsbIAF yAPA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=ZU4vs3uYXNNeg/ZoifC7SKCI1QmuNrGIaaaLcVGgTyo=; b=fuQ0agvaKK2K16HAMSkS3W8J89l1M/QnjgRbeISbAgxyeFQHvtxswmI2qKyYqad/ON yKlpaJ63QLWP7pRQ1WtC+7Rw0Ylu4pQUAqMwzCYrV+kQHMAyKJvRXl4GerVYabSrfYva dHOVlEfHkUhaAPwqZqP+ttFUoOHHAXCAXTaYqngp7uxizA1eOlHJjb1fmtviwjyF+44o qAUmLV/5S99nLzdaRs+M5oZUfuXoh5O/3I6KoV7WiF8VimmPjtUL269R4WVtznwUfLR8 Ufq1X6LZE1nSz1pF2kHvv0bbbKYnznIb4wWXR6J3xO86Qc1kH9PBf/vNFxObWG+8jEmq qFsg== |
| X-Gm-Message-State | AMke39krVL4jO0mReosAKrVModJeAAYpuB+WpQar3HMrmrGpYhsc1rmi4iWYmO8bEvcG3A== |
| X-Received | by 10.84.224.7 with SMTP id r7mr4769111plj.179.1487029841738; Mon, 13 Feb 2017 15:50:41 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 26 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Maxime Ripard <maxime.ripard@free-electrons.com>, Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 13 Feb 2017 15:50:38 -0800 |
| X-Original-Message-ID | <20170213235038.GA25758@dtor-ws> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1580156 |
Show key headers only | View raw
There is no need to tread the same register twice in a row.
Fixes: ea4348c8462a ("Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-un ...")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/tca8418_keypad.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c
index 44dd7689c571..e37e335e406f 100644
--- a/drivers/input/keyboard/tca8418_keypad.c
+++ b/drivers/input/keyboard/tca8418_keypad.c
@@ -188,8 +188,6 @@ static void tca8418_read_keypad(struct tca8418_keypad *keypad_data)
input_event(input, EV_MSC, MSC_SCAN, code);
input_report_key(input, keymap[code], state);
- /* Read for next loop */
- error = tca8418_read_byte(keypad_data, REG_KEY_EVENT_A, ®);
} while (1);
input_sync(input);
--
2.11.0.483.g087da7b7c-goog
--
Dmitry
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] Input: tca8418_keypad - remove double read of key event register Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-14 01:00 +0100
csiph-web