Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1579915
| From | Michal Nazarewicz <mina86@mina86.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype |
| Date | 2017-02-13 17:10 +0100 |
| Message-ID | <tarmq-5YZ-31@gated-at.bofh.it> (permalink) |
| References | <taqTn-5xK-19@gated-at.bofh.it> <tarmp-5YZ-3@gated-at.bofh.it> |
| Organization | http://mina86.com/ |
On Mon, Feb 13 2017, Gustavo A. R. Silva wrote:
> Remove unnecessary variable and update function prototype.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> drivers/usb/gadget/udc/amd5536udc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/amd5536udc.c b/drivers/usb/gadget/udc/amd5536udc.c
> index ded97a3..3f64a06 100644
> --- a/drivers/usb/gadget/udc/amd5536udc.c
> +++ b/drivers/usb/gadget/udc/amd5536udc.c
> @@ -608,9 +608,8 @@ udc_alloc_request(struct usb_ep *usbep, gfp_t gfp)
> }
>
> /* frees pci pool descriptors of a DMA chain */
> -static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
> +static void udc_free_dma_chain(struct udc *dev, struct udc_request *req)
> {
> - int ret_val = 0;
> struct udc_data_dma *td = req->td_data;
> unsigned int i;
>
> @@ -629,8 +628,6 @@ static int udc_free_dma_chain(struct udc *dev, struct udc_request *req)
> td = NULL;
> addr = addr_aux;
> }
> -
> - return ret_val;
> }
>
> /* Frees request packet, called by gadget driver */
> --
> 2.5.0
>
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] avoid use of freed pointer "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-13 16:40 +0100
[PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-13 17:10 +0100
Re: [PATCH 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype Michal Nazarewicz <mina86@mina86.com> - 2017-02-13 17:10 +0100
Re: [PATCH 1/2] usb: gadget: udc: avoid use of freed pointer Michal Nazarewicz <mina86@mina86.com> - 2017-02-13 17:10 +0100
Re: [PATCH 1/2] usb: gadget: udc: avoid use of freed pointer "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 23:00 +0100
[PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 23:00 +0100
[PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 23:10 +0100
[PATCH 1/2] usb: gadget: udc: avoid use of freed pointer "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-13 17:10 +0100
csiph-web