Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579907

Re: [PATCH] x86/vm86: fix unused variable warning if THP is disabled.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, 13 Feb 2017, Kirill A. Shutemov wrote:

> GCC complaines on unused variable 'vma' in mark_screen_rdonly() if THP
> is disalbed:
> 
> arch/x86/kernel/vm86_32.c: In function ‘mark_screen_rdonly’:
> arch/x86/kernel/vm86_32.c:180:26: warning: unused variable ‘vma’
> [-Wunused-variable]
>    struct vm_area_struct *vma = find_vma(mm, 0xA0000);
>                              ^~~
> It shoudln't really. The whole block has to be eliminated as
> pmd_trans_huge() is 0 if THP is disabled.
 
Indeed. That's outright silly. 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86/vm86: fix compilation warning on a unused variable Borislav Petkov <bp@suse.de> - 2017-02-12 15:10 +0100
  Re: [PATCH] x86/vm86: fix compilation warning on a unused variable Jérémy Lefaure <jeremy.lefaure@lse.epita.fr> - 2017-02-13 05:40 +0100
    Re: [PATCH] x86/vm86: fix compilation warning on a unused variable Borislav Petkov <bp@suse.de> - 2017-02-13 11:10 +0100
      [PATCH] x86/vm86: fix unused variable warning if THP is disabled. "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-02-13 14:00 +0100
        Re: [PATCH] x86/vm86: fix unused variable warning if THP is  disabled. Thomas Gleixner <tglx@linutronix.de> - 2017-02-13 17:00 +0100
        Re: [PATCH] x86/vm86: fix unused variable warning if THP is disabled. Borislav Petkov <bp@suse.de> - 2017-02-13 18:50 +0100
        [tip:x86/urgent] x86/vm86: Fix unused variable warning if THP is  disabled "tip-bot for Kirill A. Shutemov" <tipbot@zytor.com> - 2017-02-13 19:10 +0100

csiph-web