Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0

From	Colin Ian King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0
Date	2017-02-13 17:50 +0100
Message-ID	<tarZ7-6el-9@gated-at.bofh.it> (permalink)
References	<ta7e1-1hK-5@gated-at.bofh.it> <tammJ-2yB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 13/02/17 10:45, Felipe Balbi wrote:
> 
> Hi,
> 
> Colin King <colin.king@canonical.com> writes:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The check for retval being less than zero is always true since
>> retval equal to -EPIPE at that point.  Replace the existing
>> conditional with just return retval.
>>
>> Detected with CoverityScan, CID#114349 ("Logically dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/usb/misc/usbtest.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c
>> index 3525626..17c0810 100644
>> --- a/drivers/usb/misc/usbtest.c
>> +++ b/drivers/usb/misc/usbtest.c
>> @@ -992,7 +992,7 @@ static int ch9_postconfig(struct usbtest_dev *dev)
>>  				dev_err(&iface->dev,
>>  						"hs dev qualifier --> %d\n",
>>  						retval);
>> -				return (retval < 0) ? retval : -EDOM;
>> +				return retval;
> 
> you're changing return value here, are you sure there's nothing else
> depending on this error?
> 
The code in the current state will never return -EDOM and will always
return retval, so this change actually makes no functional change, it
just removes a redundant check.  So it's not going to make a jot of
difference to the current behaver.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: misc: usbtest: remove redundant check on retval < 0 Colin King <colin.king@canonical.com> - 2017-02-12 19:40 +0100
  Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0 Peter Chen <hzpeterchen@gmail.com> - 2017-02-13 11:00 +0100
  Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0 Felipe Balbi <felipe.balbi@linux.intel.com> - 2017-02-13 11:50 +0100
    Re: [PATCH] usb: misc: usbtest: remove redundant check on retval <  0 Alan Stern <stern@rowland.harvard.edu> - 2017-02-13 17:50 +0100
    Re: [PATCH] usb: misc: usbtest: remove redundant check on retval < 0 Colin Ian King <colin.king@canonical.com> - 2017-02-13 17:50 +0100

csiph-web