Re: [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs
Date	2017-02-13 16:50 +0100
Message-ID	<tar35-5BW-35@gated-at.bofh.it> (permalink)
References	<t7RQ6-5AW-19@gated-at.bofh.it> <t9QZz-88b-5@gated-at.bofh.it> <tar35-5BW-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 13 February 2017 at 16:24, Jan Glauber
<jan.glauber@caviumnetworks.com> wrote:
> On Sun, Feb 12, 2017 at 09:09:29AM +0800, kbuild test robot wrote:
>> Hi Jan,
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.10-rc7 next-20170210]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url:    https://github.com/0day-ci/linux/commits/Jan-Glauber/Cavium-MMC-driver/20170206-214740
>> config: arm64-allmodconfig (attached as .config)
>> compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
>> reproduce:
>>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         # save the attached .config to linux build tree
>>         make.cross ARCH=arm64
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from drivers/mmc/host/cavium-mmc.c:28:0:
>>    drivers/mmc/host/cavium-mmc.h:41:7: warning: "CONFIG_MMC_CAVIUM_THUNDERX" is not defined [-Wundef]
>>     #elif CONFIG_MMC_CAVIUM_THUNDERX
>>           ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Hi Ulf,
>
> We are aware of this build error, the line above should be:
> #elif IS_ENABLED(CONFIG_MMC_CAVIUM_THUNDERX)

Please avoid using IS_ENABLED() - unless really needed.

Doesn't "#ifdef" work here?

>
> instead of:
> #elif CONFIG_MMC_CAVIUM_THUNDERX
>
> Unless you want it otherwise I'll wait for your review of the series
> and fix this build error with the next revision.

I have started to look at the series (I have comments). So, unless
some other provides you with relevant comments, you can wait for mine
before re-spin.

[...]

Kind regards
Uffe

Thread

[PATCH v11 0/9] Cavium MMC driver Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
  [PATCH v11 3/9] mmc: cavium: Add MMC platform driver for Octeon SOCs Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
  [PATCH v11 1/9] dt-bindings: mmc: Add Cavium SOCs MMC bindings Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
    Re: [PATCH v11 1/9] dt-bindings: mmc: Add Cavium SOCs MMC bindings Rob Herring <robh@kernel.org> - 2017-02-09 01:50 +0100
  [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
    Re: [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs Ulf Hansson <ulf.hansson@linaro.org> - 2017-02-13 16:50 +0100
      Re: [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs Arnd Bergmann <arnd@arndb.de> - 2017-02-15 13:40 +0100
  [PATCH v11 8/9] mmc: cavium: Support DDR mode for eMMC devices Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
  [PATCH v11 4/9] mmc: cavium: Work-around hardware bug on cn6xxx and cnf7xxx Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
  [PATCH v11 9/9] MAINTAINERS: Add entry for Cavium MMC driver Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
  [PATCH v11 2/9] mmc: cavium: Add core MMC driver for Cavium SOCs Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100
  [PATCH v11 5/9] mmc: cavium: Add support for Octeon cn7890 Jan Glauber <jglauber@cavium.com> - 2017-02-06 14:50 +0100

csiph-web