Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579877

Re: [PATCH - REGRESSION] mwifiex: don't enable/disable IRQ 0 during suspend/resume

Show all headers | View raw

Brian Norris <briannorris@chromium.org> writes:

> If we don't have an out-of-band wakeup IRQ configured through DT (as
> most platforms don't), then we fall out of this function with
> 'irq_wakeup == 0'. Other code (e.g., mwifiex_disable_wake() and
> mwifiex_enable_wake()) treats 'irq_wakeup >= 0' as a valid IRQ, and so
> we end up calling {enable,disable}_irq() on IRQ 0.
>
> That seems bad, so let's not do that.
>
> Same problem as fixed in this patch:
>
> https://patchwork.kernel.org/patch/9531693/
> [PATCH v2 2/3] btmrvl: set irq_bt to -1 when failed to parse it
>
> with the difference that:
> (a) this one is actually a regression and
> (b) this affects both device tree and non-device-tree systems
>
> While fixing the regression, also drop the verbosity on the parse
> failure, so we don't see this when a DT node is present but doesn't have
> an interrupt property (this is perfectly legal):
>
> [   21.999000] mwifiex_pcie 0000:01:00.0: fail to parse irq_wakeup from device tree
>
> Fixes: 853402a00823 ("mwifiex: Enable WoWLAN for both sdio and pcie")
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> This is a 4.10 regression. Not sure if it's critical to push quickly, or if it
> should just be tagged -stable and pushed in 4.11.

It's really late for 4.10, so I would rather push it to 4.11.

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH - REGRESSION] mwifiex: don't enable/disable IRQ 0 during suspend/resume Brian Norris <briannorris@chromium.org> - 2017-02-10 23:00 +0100
  Re: [PATCH - REGRESSION] mwifiex: don't enable/disable IRQ 0 during suspend/resume Kalle Valo <kvalo@codeaurora.org> - 2017-02-13 16:40 +0100
  Re: [PATCH - REGRESSION] mwifiex: don't enable/disable IRQ 0 during suspend/resume Rajat Jain <rajatja@google.com> - 2017-02-13 21:00 +0100
  Re: [-,  REGRESSION] mwifiex: don't enable/disable IRQ 0 during suspend/resume Kalle Valo <kvalo@codeaurora.org> - 2017-02-15 10:20 +0100

csiph-web