Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579788

Re: [PATCH 2/3] pinctrl: spear: make bool drivers explicitly non-modular

Show all headers | View raw

On Mon, Feb 6, 2017 at 9:03 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> None of the Kconfigs for any of these drivers are tristate,
> meaning that they currently are not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the drivers there is no doubt they are builtin-only.  All
> drivers get the exact same change, so they are handled in batch.
>
> Changes are (1) use init.h header in place of module.h header,
> (2) delete module_exit related code, (3) delete MODULE_DEVICE_TABLE,
> and (4) delete MODULE_LICENCE/MODULE_AUTHOR and associated tags.
>
> None of these drivers were using module_init() so we don't have to
> worry about the init ordering getting changed with this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE etc. tags since all that information
> is already contained at the top of each file in the comments.
>
> Cc: Viresh Kumar <vireshk@kernel.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: spear-devel@list.st.com
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/3] pinctrl: spear: make bool drivers explicitly non-modular Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-02-06 09:10 +0100
  Re: [PATCH 2/3] pinctrl: spear: make bool drivers explicitly  non-modular Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-07 05:20 +0100
  Re: [PATCH 2/3] pinctrl: spear: make bool drivers explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2017-02-13 14:30 +0100

csiph-web