Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579660

Re: [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards

Show all headers | View raw

Hello Andi,

On 02/11/2017 01:44 AM, Andi Shyti wrote:
> Hi Javier,
> 
> On Fri, Feb 10, 2017 at 11:04:50AM -0300, Javier Martinez Canillas wrote:
>> On 02/09/2017 11:22 PM, Andi Shyti wrote:
> ...
>>> +	irda_regulator: irda-regulator {
>>> +		compatible = "regulator-fixed";
>>> +		enable-active-high;
>>> +		gpio = <&gpr3 3 GPIO_ACTIVE_HIGH>;
>>> +		regulator-name = "irda_regulator";
>>
>> How is this regulator named in the board schematics? My
>> understanding is that regulator-name should match this.
>>
>> I don't have access to this so it may be "irda_regulator"
>> although I was expecting something more like "VDD_IRDA".
> 
> This is not a real regulator.
>

I see, I misunderstood and thought it was a real regulator.
 
> This is an external regulator which is enabled with a gpio
> (GPR3[3]). The regulator-fixed allows me to use the regulator API
> even though I would only need to control a gpio (with the gpio
> API). I prefer using regulator to keep the same interface no
> matter how the irda is connected.
>
> About the name, I have full freedom to chose as of course it's
> not documented in the exynos5433 datasheet. Perhaps I could call
> it irda-gpio-regulator to make it more clear?
>

I don't have a strong opinion on the regulator-name in this
case.

>> Patch looks good to me though:
>>
>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Thanks,
> Andi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Andi Shyti <andi.shyti@samsung.com> - 2017-02-10 04:00 +0100
  Re: [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Krzysztof Kozlowski <krzk@kernel.org> - 2017-02-10 14:50 +0100
  Re: [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-10 15:10 +0100
    Re: [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Andi Shyti <andi.shyti@samsung.com> - 2017-02-11 05:50 +0100
      Re: [PATCH v2] arm64: dts: Enable ir-spi in the tm2 and tm2e boards Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-13 13:00 +0100

csiph-web