Re: [linux-sunxi] [PATCH 1/8] ARM: sunxi_defconfig: Enable simple panel

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [linux-sunxi] [PATCH 1/8] ARM: sunxi_defconfig: Enable simple panel
Date	2017-02-13 05:10 +0100
Message-ID	<tag7E-6VH-9@gated-at.bofh.it> (permalink)
References	<t9JY6-3Bh-3@gated-at.bofh.it> <t9JY6-3Bh-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 12, 2017 at 1:43 AM, Priit Laes <plaes@plaes.org> wrote:
> From: Jonathan Liu <net147@gmail.com>
>

This needs a commit message about why these need to be enabled, like

"Most Allwinner tablets use the same design of a dumb LCD panel coupled
 with a PWM controlled backlight."

Also the subject does not mention CONFIG_BACKLIGHT_PWM being enabled.

> Signed-off-by: Jonathan Liu <net147@gmail.com>

Since you are resending the patch, you must also add your SoB.

ChenYu

> ---
>  arch/arm/configs/sunxi_defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/configs/sunxi_defconfig b/arch/arm/configs/sunxi_defconfig
> index da92c25..7abe6a4 100644
> --- a/arch/arm/configs/sunxi_defconfig
> +++ b/arch/arm/configs/sunxi_defconfig
> @@ -153,3 +153,7 @@ CONFIG_NLS_ISO8859_1=y
>  CONFIG_PRINTK_TIME=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_CRYPTO_DEV_SUN4I_SS=y
> +CONFIG_BACKLIGHT_CLASS_DEVICE=y
> +CONFIG_BACKLIGHT_LCD_SUPPORT=y
> +CONFIG_BACKLIGHT_PWM=y
> +CONFIG_DRM_PANEL_SIMPLE=y
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/8] ARM: sunxi_defconfig: Enable simple panel Priit Laes <plaes@plaes.org> - 2017-02-11 18:50 +0100
  Re: [linux-sunxi] [PATCH 1/8] ARM: sunxi_defconfig: Enable simple panel Chen-Yu Tsai <wens@csie.org> - 2017-02-13 05:10 +0100

csiph-web