Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579304

Re: [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro

Show all headers | View raw

On Mon, Feb 13, 2017 at 03:26:37AM +0530, simran singhal wrote:
> Fix the checkpatch.pl issue:
> CHECK: Prefer using the BIT macro replacing
> bit shifting on 1 with the BIT(x) macro.
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 ++++++++++++-------------
>  1 file changed, 70 insertions(+), 70 deletions(-)

Didn't you send this before?  If so, this should be a v2 patch, right?
And if so, please always say _what_ changed between versions, see
Documentation/SubmittingPatches for how to properly label this.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro simran singhal <singhalsimran0@gmail.com> - 2017-02-12 23:00 +0100
  Re: [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro Greg KH <gregkh@linuxfoundation.org> - 2017-02-12 23:20 +0100
    Re: [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-13 10:20 +0100
      Re: [PATCH 3/20] staging: rtl8192u: Prefer using the BIT macro Greg KH <gregkh@linuxfoundation.org> - 2017-02-13 12:50 +0100

csiph-web