Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1581034

Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues

From SIMRAN SINGHAL <singhalsimran0@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues
Date 2017-02-15 04:30 +0100
Message-ID <taYs2-2jy-7@gated-at.bofh.it> (permalink)
References <taRJU-6oO-19@gated-at.bofh.it> <taRTA-6sk-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Yes, I totally agree with joe.

But as there is no coding style issue in this patch.
So, do I have to resend the complete patch series again?


On Wed, Feb 15, 2017 at 1:53 AM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2017-02-15 at 01:44 +0530, simran singhal wrote:
> []
>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
> []
>> @@ -150,14 +150,15 @@ static inline char *rtl819x_translate_scan(struct ieee80211_device *ieee,
>>               PHT_CAPABILITY_ELE ht_cap = NULL;
>>               bool is40M = false, isShortGI = false;
>>               u8 max_mcs = 0;
>> +
>>               if (!memcmp(network->bssht.bdHTCapBuf, EWC11NHTCap, 4))
>>                       ht_cap = (PHT_CAPABILITY_ELE)&network->bssht.bdHTCapBuf[4];
>>               else
>>                       ht_cap = (PHT_CAPABILITY_ELE)&network->bssht.bdHTCapBuf[0];
>> -             is40M = (ht_cap->ChlWidth)?1:0;
>> -             isShortGI = (ht_cap->ChlWidth)?
>> -                                             ((ht_cap->ShortGI40Mhz)?1:0):
>> -                                             ((ht_cap->ShortGI20Mhz)?1:0);
>> +             is40M = (ht_cap->ChlWidth) ? 1 : 0;
>> +             isShortGI = (ht_cap->ChlWidth) ?
>> +                                             ((ht_cap->ShortGI40Mhz) ? 1 : 0) :
>> +                                             ((ht_cap->ShortGI20Mhz) ? 1 : 0);
>
> You have a brain, checkpatch is brainless.
> Please remember to do more than just shut-up checkpatch.
>
> This could be simplified by removing parentheses and ternaries to
>
>                 isShortGI = ht_cap->Ch1Width ? ht_cap->ShortGI40Mhz
>                                              : ht_cap->ShortGI20Mhz;
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues simran singhal <singhalsimran0@gmail.com> - 2017-02-14 21:20 +0100
  Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues Joe Perches <joe@perches.com> - 2017-02-14 21:30 +0100
    Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-15 04:30 +0100
      Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues Joe Perches <joe@perches.com> - 2017-02-15 04:40 +0100
        Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-15 09:20 +0100
          Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues Joe Perches <joe@perches.com> - 2017-02-15 10:30 +0100
          Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-02-16 19:40 +0100
            Re: [PATCH v2 6/9] staging: rtl8192u: Fixing coding style issues SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-16 20:10 +0100

csiph-web