Re: [PATCH] drm/rockchip: add extcon dependency for DP

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Mark yao <mark.yao@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/rockchip: add extcon dependency for DP
Date	Wed, 15 Feb 2017 02:10:01 +0100
Message-ID	<taWgx-XP-3@gated-at.bofh.it> (permalink)
References	<taSZk-75C-27@gated-at.bofh.it>
X-263anti-Spam	KSV:0;
X-Mail-Delivery	1
X-Abs-Checked	4
X-Rl-Sender	mark.yao@rock-chips.com
X-Fst-To	linux-kernel@vger.kernel.org
X-Sender-IP	58.22.7.114
X-Login-Name	mark.yao@rock-chips.com
X-Unique-Tag	<b167d38df494e3ad3ddc3cf687f2ddf7>
X-Sender	yzq@rock-chips.com
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Sean Paul <seanpaul@chromium.org>, Guenter Roeck <groeck@chromium.org>, Heiko Stuebner <heiko@sntech.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Philipp Zabel <p.zabel@pengutronix.de>, Chris Zhong <zyw@rock-chips.com>, Tobias Jakobi <tjakobi@math.uni-bielefeld.de>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 15 Feb 2017 09:06:15 +0800
X-Original-Message-ID	<58A3A987.9020001@rock-chips.com>
X-Original-References	<20170214213215.2888509-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1580978

Show key headers only | View raw

On 2017年02月15日 05:31, Arnd Bergmann wrote:
> The newly added DP driver links against the extcon core, which fails when
> extcon is a module and this driver is not:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
>
> Let's make Kconfig enforce correct behavior with a dependency.

Thanks for the fix.

Applied to my drm-next.

> Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/gpu/drm/rockchip/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index ad31b3eb408f..0e4eb845cbb0 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
>   config ROCKCHIP_CDN_DP
>           tristate "Rockchip cdn DP"
>           depends on DRM_ROCKCHIP
> +	depends on EXTCON
>   	select SND_SOC_HDMI_CODEC if SND_SOC
>           help
>   	  This selects support for Rockchip SoC specific extensions


-- 
Ｍark Yao

Thread

[PATCH] drm/rockchip: add extcon dependency for DP Arnd Bergmann <arnd@arndb.de> - 2017-02-14 22:40 +0100
  Re: [PATCH] drm/rockchip: add extcon dependency for DP Guenter Roeck <groeck@google.com> - 2017-02-14 23:10 +0100
  Re: [PATCH] drm/rockchip: add extcon dependency for DP Mark yao <mark.yao@rock-chips.com> - 2017-02-15 02:10 +0100
  Re: [PATCH] drm/rockchip: add extcon dependency for DP Sean Paul <seanpaul@chromium.org> - 2017-02-23 18:00 +0100

csiph-web