[PATCH] IB/hfi1: use size_t for passing array length

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] IB/hfi1: use size_t for passing array length
Date	Tue, 14 Feb 2017 22:30:03 +0100
Message-ID	<taSPF-72f-27@gated-at.bofh.it> (permalink)
X-Original-To	Mike Marciniszyn <mike.marciniszyn@intel.com>, Dennis Dalessandro <dennis.dalessandro@intel.com>
X-Mailer	git-send-email 2.9.0
X-Provags-ID	V03:K0:edZvJHA9ZJtzLyJ3cy94JJ7Wc4w0KA5NFAc+21awroeGgMCKjJP vWvNWHpgR1qLjJAe4LRSAdNwoVOWCDhl5MiHp0OebnGsWKzoF4PjfZhGQ2OAMfCH/eRjE9y tCDqmQs8RIFjSzsLwY9tlkCoGLIxyPlxdBMk4FQS4Bqj5M//rnIN+ot5QL+EiuwInrw/Mxe Dj7o0rNv54OpLRZcpmSnw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:550fFSWMXMU=:Xm7ddIjqtDAEF6fQ1yG0ab JZMxDTz5hC0/fO4fMmsfyl7Yy+XuE6a6UH+rGDfNCxx75RP49XYLl0yM6tkZ0CbTGEvRw6HRO MD7qOlqduG2AA5O7kqpuVo1gNy9KM3KyHnqSHoar7B/NRXiyLdog/2kol4gO2fd38SG/mVorB /zzUtlZrgAcYvk9afXDb1mfGa3J1z55V5dD+MAQ9jzRjJwMSYU855bF+8DkuwFeN6GudjAlbq 5Ylz/d8kX5pBb3V09uxzWx3gPYJCuCeoVaLD6WtlyBE3vQfvpiDGLIPkslf1MoS+oB8NktVQh sfq2SiaErdVOUfVqED6iLLJf4Yy/gSW158Q0gCD7pxM4ONehyoPx/MweQlEF27L5IVzCewAf+ swOuZWJGEoSR1r21fxNDEmTvi+tWKr6+Bv4JcGOXf+7GKQtf5C+vjg7Prtpyvkd7Q9XWUNmb3 M4/lZB5t07yovy6hoQUmGLn88WU+vCGsoGQiIOa2q78uZpheXmqMwA2oqkrooOpBL2R8Lt0/6 tY4vq6wrSV/tq8ZrVTVfASesc2oaSm62DENVDuEEB/gxzJilyT5AWFhe4z4zjE5Z7yksf+L35 AzAgvkgsHKc8AFK8LXgFh1c4nmB2wd7xzHikH80cfYDgUk/TCTWfow2mUCpv/v6dbz1Xi92aF WPfQHsxXDjn4ymiR5g/Zn7co5OrpXryMHyuRr82TRg5flH9EVNOHMUiyusgxbt07Tyv8=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Arnd Bergmann <arnd@arndb.de>, Doug Ledford <dledford@redhat.com>, Sean Hefty <sean.hefty@intel.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Ira Weiny <ira.weiny@intel.com>, Jubin John <jubin.john@intel.com>, Jianxin Xiong <jianxin.xiong@intel.com>, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 14 Feb 2017 22:23:07 +0100
X-Original-Message-ID	<20170214212358.2730288-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1580877

Show key headers only | View raw

gcc-7 produces a mysterious warning about the size argument being potentially out
of range:

drivers/infiniband/hw/hfi1/verbs.c: In function 'init_cntr_names':
drivers/infiniband/hw/hfi1/verbs.c:1644:2: error: 'memcpy': specified size between 18446744071562067968 and 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Werror=stringop-overflow=]

This seems to refer to a the case where an 64-bit size_t gets truncated
into a negative 'int' and subsequently turned into a high 64-bit number
again.

The fix is clearly to use size_t here, which matches the type that gets
used for this value elsewhere.

Fixes: b7481944b06e ("IB/hfi1: Show statistics counters under IB stats interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/infiniband/hw/hfi1/verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
index 95ed4d6da510..1d8ac9432742 100644
--- a/drivers/infiniband/hw/hfi1/verbs.c
+++ b/drivers/infiniband/hw/hfi1/verbs.c
@@ -1618,7 +1618,7 @@ static int cntr_names_initialized;
  * external strings.
  */
 static int init_cntr_names(const char *names_in,
-			   const int names_len,
+			   const size_t names_len,
 			   int num_extra_names,
 			   int *num_cntrs,
 			   const char ***cntr_names)
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] IB/hfi1: use size_t for passing array length Arnd Bergmann <arnd@arndb.de> - 2017-02-14 22:30 +0100
  Re: [PATCH] IB/hfi1: use size_t for passing array length Leon Romanovsky <leon@kernel.org> - 2017-02-15 06:30 +0100
  Re: [PATCH] IB/hfi1: use size_t for passing array length Doug Ledford <dledford@redhat.com> - 2017-02-19 15:00 +0100

csiph-web