Re: [PATCH v3] clk: add more managed APIs

From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] clk: add more managed APIs
Date	2017-02-14 20:50 +0100
Message-ID	<taRgS-5Z8-37@gated-at.bofh.it> (permalink)
References	(4 earlier) <t4KUN-7Wl-5@gated-at.bofh.it> <t525k-1Vo-21@gated-at.bofh.it> <t5puV-7L5-3@gated-at.bofh.it> <t5uXE-2p9-15@gated-at.bofh.it> <t856G-5QF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/06, Dmitry Torokhov wrote:
> On Mon, Jan 30, 2017 at 04:57:13PM -0800, Dmitry Torokhov wrote:
> > When converting a driver to managed resources it is desirable to be able to
> > manage all resources in the same fashion. This change allows managing clock
> > prepared and enabled state in the same way we manage many other resources.
> > 
> > This adds the following managed APIs:
> > 
> > - devm_clk_prepare()/devm_clk_unprepare();
> > - devm_clk_prepare_enable()/devm_clk_disable_unprepare().
> > 
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> It would be awesome if we could get it into 4.11...

I'd prefer we didn't do this. Instead, make clk_put() drop any
prepare or enables that were done via that clk pointer. Mike
started to do this before[1], but we have some code that assumes
it can do:

	clk = clk_get(...)
	clk_prepare_enable(clk)
	clk_put(clk)

and have the clk stay on. Those would need to be changed.

We would also need Russell's approval to update the clk_put()
documentation to describe this change in behavior.

[1] http://lkml.kernel.org/r/1438974570-20812-1-git-send-email-mturquette@baylibre.com

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] clk: add more managed APIs Stephen Boyd <sboyd@codeaurora.org> - 2017-02-14 20:50 +0100
  Re: [PATCH v3] clk: add more managed APIs Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-14 21:00 +0100
    Re: [PATCH v3] clk: add more managed APIs Guenter Roeck <linux@roeck-us.net> - 2017-02-14 21:40 +0100
  Re: [PATCH v3] clk: add more managed APIs Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-14 21:10 +0100

csiph-web