Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580829

[PATCH 8/8] net: stmmac: invert the logic for dumping regs

Show all headers | View raw

It is easier to follow the logic by removing the not operator

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index aab895d..5ff6bc4 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -442,24 +442,24 @@ static void stmmac_ethtool_gregs(struct net_device *dev,
 
 	memset(reg_space, 0x0, REG_SPACE_SIZE);
 
-	if (!(priv->plat->has_gmac || priv->plat->has_gmac4)) {
+	if (priv->plat->has_gmac || priv->plat->has_gmac4) {
 		/* MAC registers */
-		for (i = 0; i < 12; i++)
+		for (i = 0; i < 55; i++)
 			reg_space[i] = readl(priv->ioaddr + (i * 4));
 		/* DMA registers */
-		for (i = 0; i < 9; i++)
-			reg_space[i + 12] =
+		for (i = 0; i < 22; i++)
+			reg_space[i + 55] =
 			    readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));
-		reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);
-		reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);
 	} else {
 		/* MAC registers */
-		for (i = 0; i < 55; i++)
+		for (i = 0; i < 12; i++)
 			reg_space[i] = readl(priv->ioaddr + (i * 4));
 		/* DMA registers */
-		for (i = 0; i < 22; i++)
-			reg_space[i + 55] =
+		for (i = 0; i < 9; i++)
+			reg_space[i + 12] =
 			    readl(priv->ioaddr + (DMA_BUS_MODE + (i * 4)));
+		reg_space[22] = readl(priv->ioaddr + DMA_CUR_TX_BUF_ADDR);
+		reg_space[23] = readl(priv->ioaddr + DMA_CUR_RX_BUF_ADDR);
 	}
 }
 
-- 
2.10.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] net: stmmac: misc patchs Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:00 +0100
  [PATCH 3/8] net: stmmac: use SPEED_UNKNOWN/DUPLEX_UNKNOWN Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:00 +0100
  [PATCH 4/8] net: stmmac: set speed at SPEED_UNKNOWN in case of broken speed Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:00 +0100
  [PATCH 2/8] net: stmmac: likely is useless in occasional function Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:00 +0100
  [PATCH 6/8] net: stmmac: split the stmmac_adjust_link 10/100 case Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:00 +0100
  [PATCH 7/8] net: stmmac: reduce indentation by adding a continue Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:10 +0100
  [PATCH 5/8] net: stmmac: run stmmac_hw_fix_mac_speed when speed is valid Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:10 +0100
  [PATCH 8/8] net: stmmac: invert the logic for dumping regs Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-14 21:10 +0100
  Re: [PATCH 0/8] net: stmmac: misc patchs Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-02-15 07:40 +0100
    Re: [PATCH 0/8] net: stmmac: misc patchs Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-15 08:40 +0100
      Re: [PATCH 0/8] net: stmmac: misc patchs Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-02-15 10:20 +0100

csiph-web