Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86

From	"H. Peter Anvin" <hpa@zytor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86
Date	2017-02-14 19:50 +0100
Message-ID	<taQkN-5op-5@gated-at.bofh.it> (permalink)
References	<ta9IR-2Tv-1@gated-at.bofh.it> <ta9IR-2Tv-5@gated-at.bofh.it> <taNZD-44x-13@gated-at.bofh.it> <taPyp-4RU-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/14/17 09:56, Geert Uytterhoeven wrote:
>>
>> Well, almost. You need the wp_works_ok removal patch too, otherwise you
>> have the 3 bytes hole below.
> 
> That's because you removed a char in commit 93a829e8e2c292f1
> ("x86, cpu: Convert FDIV bug detection), without compensating with padding ;-)
> 

Padding isn't a problem (other than efficiency) for a structure which is
strictly internal to the kernel as opposed to an ABI structure.

	-hpa

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 Borislav Petkov <bp@alien8.de> - 2017-02-14 17:20 +0100
  Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 Mathias Krause <minipli@googlemail.com> - 2017-02-14 17:50 +0100
  Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-14 19:00 +0100
    Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 Borislav Petkov <bp@alien8.de> - 2017-02-14 19:30 +0100
    Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 "H. Peter Anvin" <hpa@zytor.com> - 2017-02-14 19:50 +0100

csiph-web