Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580685

Re: [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart

Show all headers | View raw

On Tue, Feb 14, 2017 at 3:19 AM, Chunyan Zhang
<chunyan.zhang@spreadtrum.com> wrote:
> This patch revise the compatible string of sprd uart to "sc-uart"
> since this driver is not only for SC9836, but for all Spreadtrum
> SoCs so far.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
> ---
>  Documentation/devicetree/bindings/serial/sprd-uart.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> index 2aff0f2..9b0ad52 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> @@ -1,7 +1,7 @@
>  * Spreadtrum serial UART
>
>  Required properties:
> -- compatible: must be "sprd,sc9836-uart"
> +- compatible: must be "sprd,sc-uart"

You can't just change compatible strings.

You don't need a generic-ish compatible if other SoCs have "the same"
uart. Then you just do: '"sprd,sc<new soc>-uart", "sprd,sc9836-uart"'
in the DT. The existing driver will work matching on sprd,sc9836-uart
and if you ever find some difference in the uarts you have the more
specific compatible string to handle that.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-02-14 10:50 +0100
  Re: [PATCH 3/5] devicetree: bindings: revise compatible string of  sprd uart Rob Herring <robh+dt@kernel.org> - 2017-02-14 18:10 +0100

csiph-web