Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1580638

Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests

From Shuah Khan <shuahkh@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests
Date 2017-02-14 17:20 +0100
Message-ID <taNZD-44x-19@gated-at.bofh.it> (permalink)
References <t8STL-4gx-3@gated-at.bofh.it> <taAJ3-3JR-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 02/13/2017 07:09 PM, Michael Ellerman wrote:
> Michael Ellerman <mpe@ellerman.id.au> writes:
> 
>> In commit 88baa78d1f31 ("selftests: remove duplicated all and clean
>> target"), the "all" target was removed from individual Makefiles and
>> added to lib.mk.
>>
>> However the "all" target was added to lib.mk *after* the existing
>> "runtests" target. This means "runtests" becomes the first (default)
>> target for most of our Makefiles.
> ...
>>
>> Fix it by moving the "all" target to the start of lib.mk, making it the
>> default target.
>>
>> Fixes: 88baa78d1f31 ("selftests: remove duplicated all and clean target")
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> 
> Hi Shuah,
> 
> Can you please merge this series into linux-next?
> 
> The selftests are badly broken otherwise.
> 
> cheers
> 

Hi Michael,

Thanks. All 5 patches are now in linux-kselftest next with Tested-by
tag from Bamvor for 1,2,3.

thank you both,
-- Shuah

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests Michael Ellerman <mpe@ellerman.id.au> - 2017-02-14 03:10 +0100
  Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run  tests Shuah Khan <shuahkh@osg.samsung.com> - 2017-02-14 17:20 +0100
    Re: [PATCH 1/5] selftests: Fix selftests build to just build, not run tests Michael Ellerman <michael@ellerman.id.au> - 2017-02-14 21:40 +0100

csiph-web