Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580625

Re: [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev()

Show all headers | View raw

On Tue, Feb 14, 2017 at 11:29:03PM +0800, Ming Lei wrote:
> Firstly bio_clone_mddev() is used in raid normal I/O and isn't
> in resync I/O path.
> 
> Secondly all the direct access to bvec table in raid happens on
> resync I/O except for write behind of raid1, in which we still
> use bio_clone() for allocating new bvec table.
> 
> So this patch replaces bio_clone() with bio_clone_fast()
> in bio_clone_mddev().
> 
> Also kill bio_clone_mddev() and call bio_clone_fast() directly, as
> suggested by Christoph Hellwig.
> 
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Btw, can you also tack on another patch to kill bio_alloc_mddev
to be consistent?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] md: use bio_clone_fast() Ming Lei <tom.leiming@gmail.com> - 2017-02-14 16:30 +0100
  [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev() Ming Lei <tom.leiming@gmail.com> - 2017-02-14 16:40 +0100
    Re: [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev() Christoph Hellwig <hch@infradead.org> - 2017-02-14 17:10 +0100
      Re: [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev() Shaohua Li <shli@kernel.org> - 2017-02-15 20:30 +0100
        Re: [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev() Shaohua Li <shli@kernel.org> - 2017-02-16 01:00 +0100
  [PATCH v2 4/5] md: remove unnecessary check on mddev Ming Lei <tom.leiming@gmail.com> - 2017-02-14 16:40 +0100
  [PATCH v2 1/5] block: introduce bio_clone_bioset_partial() Ming Lei <tom.leiming@gmail.com> - 2017-02-14 16:40 +0100
  Re: [PATCH v2 0/5] md: use bio_clone_fast() Shaohua Li <shli@kernel.org> - 2017-02-15 20:30 +0100

csiph-web