Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580481
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 2/2] powerpc/mm/autonuma: Switch ppc64 to its own implementeation of saved write |
| Date | 2017-02-14 12:10 +0100 |
| Message-ID | <taJ9E-186-23@gated-at.bofh.it> (permalink) |
| References | <taE0i-5U6-1@gated-at.bofh.it> <taE0i-5U6-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes:
> diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
> index 0735d5a8049f..8720a406bbbe 100644
> --- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h
> +++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h
> @@ -16,6 +16,9 @@
> #include <asm/page.h>
> #include <asm/bug.h>
>
> +#ifndef __ASSEMBLY__
> +#include <linux/mmdebug.h>
> +#endif
I assume that's for the VM_BUG_ON() you add below. But if so wouldn't
the #include be better placed in book3s/64/pgtable.h also?
> diff --git a/arch/powerpc/include/asm/book3s/64/pgtable.h b/arch/powerpc/include/asm/book3s/64/pgtable.h
> index fef738229a68..c684ef6cbd10 100644
> --- a/arch/powerpc/include/asm/book3s/64/pgtable.h
> +++ b/arch/powerpc/include/asm/book3s/64/pgtable.h
> @@ -512,6 +512,32 @@ static inline pte_t pte_mkhuge(pte_t pte)
> return pte;
> }
>
> +#define pte_mk_savedwrite pte_mk_savedwrite
> +static inline pte_t pte_mk_savedwrite(pte_t pte)
> +{
> + /*
> + * Used by Autonuma subsystem to preserve the write bit
> + * while marking the pte PROT_NONE. Only allow this
> + * on PROT_NONE pte
> + */
> + VM_BUG_ON((pte_raw(pte) & cpu_to_be64(_PAGE_PRESENT | _PAGE_RWX | _PAGE_PRIVILEGED)) !=
> + cpu_to_be64(_PAGE_PRESENT | _PAGE_PRIVILEGED));
> + return __pte(pte_val(pte) & ~_PAGE_PRIVILEGED);
> +}
> +
cheers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 0/2] Numabalancing preserve write fix "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-02-14 06:40 +0100
[PATCH V2 1/2] mm/autonuma: Let architecture override how the write bit should be stashed in a protnone pte. "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-02-14 06:40 +0100
Re: [PATCH V2 1/2] mm/autonuma: Let architecture override how the write bit should be stashed in a protnone pte. Michael Ellerman <michaele@au1.ibm.com> - 2017-02-14 07:00 +0100
Re: [PATCH V2 1/2] mm/autonuma: Let architecture override how the write bit should be stashed in a protnone pte. "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-02-14 07:00 +0100
Re: [PATCH V2 1/2] mm/autonuma: Let architecture override how the write bit should be stashed in a protnone pte. Michael Ellerman <michaele@au1.ibm.com> - 2017-02-14 12:10 +0100
Re: [PATCH V2 1/2] mm/autonuma: Let architecture override how the write bit should be stashed in a protnone pte. Andrew Morton <akpm@linux-foundation.org> - 2017-02-15 01:30 +0100
[PATCH V2 2/2] powerpc/mm/autonuma: Switch ppc64 to its own implementeation of saved write "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-02-14 06:40 +0100
Re: [PATCH V2 2/2] powerpc/mm/autonuma: Switch ppc64 to its own implementeation of saved write Michael Ellerman <mpe@ellerman.id.au> - 2017-02-14 12:10 +0100
Re: [PATCH V2 2/2] powerpc/mm/autonuma: Switch ppc64 to its own implementeation of saved write "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2017-02-14 13:30 +0100
Re: [PATCH V2 2/2] powerpc/mm/autonuma: Switch ppc64 to its own implementeation of saved write Michael Ellerman <mpe@ellerman.id.au> - 2017-02-15 01:50 +0100
csiph-web