Re: [PATCH] powerpc/xmon: Fix data-breakpoint

From	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] powerpc/xmon: Fix data-breakpoint
Date	2017-02-14 09:50 +0100
Message-ID	<taGYa-7UK-5@gated-at.bofh.it> (permalink)
References	<sGfyN-5hl-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Michael,

Can you please pull this patch.

Thanks,
Ravi

On Tuesday 22 November 2016 02:55 PM, Ravi Bangoria wrote:
> Xmon data-breakpoint feature is broken.
>
> Whenever there is a watchpoint match occurs, hw_breakpoint_handler will
> be called by do_break via notifier chains mechanism. If watchpoint is
> registered by xmon, hw_breakpoint_handler won't find any associated
> perf_event and returns immediately with NOTIFY_STOP. Similarly, do_break
> also returns without notifying to xmon.
>
> Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not
> find any perf_event associated with matched watchpoint.
>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kernel/hw_breakpoint.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c
> index 03d089b..469d86d 100644
> --- a/arch/powerpc/kernel/hw_breakpoint.c
> +++ b/arch/powerpc/kernel/hw_breakpoint.c
> @@ -228,8 +228,10 @@ int hw_breakpoint_handler(struct die_args *args)
>  	rcu_read_lock();
>
>  	bp = __this_cpu_read(bp_per_reg);
> -	if (!bp)
> +	if (!bp) {
> +		rc = NOTIFY_DONE;
>  		goto out;
> +	}
>  	info = counter_arch_bp(bp);
>
>  	/*

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] powerpc/xmon: Fix data-breakpoint Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2017-02-14 09:50 +0100

csiph-web