Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes

From	Richard Cochran <richardcochran@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes
Date	2017-02-14 09:50 +0100
Message-ID	<taGYa-7UK-27@gated-at.bofh.it> (permalink)
References	<taCrw-4Mc-13@gated-at.bofh.it> <taCrw-4Mc-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 13, 2017 at 07:51:07PM -0800, Dmitry Torokhov wrote:
> Instead of creating selected attributes after the device is created (and
> after userspace potentially seen uevent), lets use attribute group
> is_visible() method to control which attributes are shown. This will allow
> us to create all attributes (except "pins" group, which will be taken care
> of later) before userspace gets notified about new ptp class device.

At first glance, this patch and the next look like nice improvements.
I don't futz around with sysfs code very often, and so may I ask how
or whether you tested it?

Thanks,
Richard

Thread

[PATCH 1/4] ptp: do not explicitly set drvdata in ptp_clock_register() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-14 05:00 +0100
  [PATCH 2/4] ptp: use kcalloc/kmallco_array when allocating arrays Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-14 05:00 +0100
    Re: [PATCH 2/4] ptp: use kcalloc/kmallco_array when allocating arrays Richard Cochran <richardcochran@gmail.com> - 2017-02-14 09:40 +0100
  [PATCH 3/4] ptp: use is_visible method to hide unused attributes Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-14 05:00 +0100
    Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes Richard Cochran <richardcochran@gmail.com> - 2017-02-14 09:50 +0100
      Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-14 19:10 +0100
        Re: [PATCH 3/4] ptp: use is_visible method to hide unused attributes Richard Cochran <richardcochran@gmail.com> - 2017-02-14 19:20 +0100
  [PATCH 4/4] ptp: create "pins" together with the rest of attributes Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-14 05:00 +0100
  Re: [PATCH 1/4] ptp: do not explicitly set drvdata in  ptp_clock_register() Richard Cochran <richardcochran@gmail.com> - 2017-02-14 09:40 +0100

csiph-web