Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580341

[tip:perf/core] tools lib traceevent: Initialize lenght on OLD_RING_BUFFER_TYPE_TIME_STAMP

Show all headers | View raw

Commit-ID:  14e4d7e0abfdefabea2b8796c5a8b2b9c77b5326
Gitweb:     http://git.kernel.org/tip/14e4d7e0abfdefabea2b8796c5a8b2b9c77b5326
Author:     Steven Rostedt (VMware) <rostedt@goodmis.org>
AuthorDate: Mon, 13 Feb 2017 12:11:44 -0500
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 13 Feb 2017 17:22:32 -0300

tools lib traceevent: Initialize lenght on OLD_RING_BUFFER_TYPE_TIME_STAMP

A undefined value was being used for the OLD_RING_BUFFER_TYPE_TIME_STAMP
case entry, as the 'length' variable was not being initialized, fix it.

Caught by the reporter when building tools/perf/ using clang, which emmitted
this warning:

  kbuffer-parse.c:312:7: warning: variable 'length' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
          case OLD_RINGBUF_TYPE_TIME_EXTEND:
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
  kbuffer-parse.c:339:29: note: uninitialized use occurs here
          kbuf->next = kbuf->index + length;
                                   ^~~~~~
  kbuffer-parse.c:297:21: note: initialize the variable 'length' to silence this warning
          unsigned int length;
                             ^
                              = 0

Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20170213121418.47f279e8@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/kbuffer-parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c
index 65984f1..c94e364 100644
--- a/tools/lib/traceevent/kbuffer-parse.c
+++ b/tools/lib/traceevent/kbuffer-parse.c
@@ -315,6 +315,7 @@ static unsigned int old_update_pointers(struct kbuffer *kbuf)
 		extend += delta;
 		delta = extend;
 		ptr += 4;
+		length = 0;
 		break;
 
 	case OLD_RINGBUF_TYPE_TIME_STAMP:

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] building libtraceevent with clang Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-10 18:10 +0100
  Re: [PATCH] building libtraceevent with clang Steven Rostedt <rostedt@goodmis.org> - 2017-02-10 20:20 +0100
    Re: [PATCH] building libtraceevent with clang Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-13 17:30 +0100
      Re: [PATCH] building libtraceevent with clang Steven Rostedt <rostedt@goodmis.org> - 2017-02-13 18:20 +0100
        Re: [PATCH] building libtraceevent with clang Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-13 18:30 +0100
          Re: [PATCH] building libtraceevent with clang Steven Rostedt <rostedt@goodmis.org> - 2017-02-13 18:50 +0100
          Re: [PATCH] building libtraceevent with clang Steven Rostedt <rostedt@goodmis.org> - 2017-02-17 03:10 +0100
            Re: [PATCH] building libtraceevent with clang Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-17 14:50 +0100
        [tip:perf/core] tools lib traceevent: Initialize lenght on  OLD_RING_BUFFER_TYPE_TIME_STAMP "tip-bot for Steven Rostedt (VMware)" <tipbot@zytor.com> - 2017-02-14 07:50 +0100
    Re: [PATCH] building libtraceevent with clang Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-13 17:30 +0100

csiph-web