Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580297
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3] usb: gadget: udc: remove pointer dereference after free |
| Date | 2017-02-14 06:00 +0100 |
| Message-ID | <taDnA-5m6-3@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <t8GpA-4sD-1@gated-at.bofh.it> <t8Iro-5Hm-23@gated-at.bofh.it> <t9Jlo-3na-15@gated-at.bofh.it> <tarmq-5YZ-23@gated-at.bofh.it> <taDnA-5m6-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Remove pointer dereference after free.
Addresses-Coverity-ID: 1091173
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
Move pointer dereference before pci_pool_free()
Set pointer to NULL after free
Changes in v3:
Remove 'td->next = 0x00' inside for loop.
Remove unnecessary pointer nullification after free.
drivers/usb/gadget/udc/pch_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/pch_udc.c
b/drivers/usb/gadget/udc/pch_udc.c
index a97da64..8a365aa 100644
--- a/drivers/usb/gadget/udc/pch_udc.c
+++ b/drivers/usb/gadget/udc/pch_udc.c
@@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct
pch_udc_dev *dev,
td = phys_to_virt(addr);
addr2 = (dma_addr_t)td->next;
pci_pool_free(dev->data_requests, td, addr);
- td->next = 0x00;
addr = addr2;
}
req->chain_len = 1;
--
2.5.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] drivers: usb: gadget: udc: remove pointer dereference after free Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-02-08 20:50 +0100
Re: [PATCH] drivers: usb: gadget: udc: remove pointer dereference after free "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-08 23:00 +0100
[PATCH v2] usb: gadget: udc: remove pointer dereference after free "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-11 18:10 +0100
Re: [PATCH v2] usb: gadget: udc: remove pointer dereference after free Michal Nazarewicz <mina86@mina86.com> - 2017-02-13 17:10 +0100
[PATCH v3] usb: gadget: udc: remove pointer dereference after free "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 06:00 +0100
Re: [PATCH v2] usb: gadget: udc: remove pointer dereference after free "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-14 06:20 +0100
csiph-web