Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580270

Re: PATCH] cpufreq: Do not clear real_cpus mask on policy init

Show all headers | View raw

On 13-02-17, 13:44, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> If new_policy is set in cpufreq_online(), the policy object has just
> been created and its real_cpus mask has been zeroed on allocation,
> and the driver's ->init() callback should not touch it.
> 
> It doesn't need to be cleared again, so don't do that.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/cpufreq/cpufreq.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq.c
> +++ linux-pm/drivers/cpufreq/cpufreq.c
> @@ -1166,8 +1166,6 @@ static int cpufreq_online(unsigned int c
>  	if (new_policy) {
>  		/* related_cpus should at least include policy->cpus. */
>  		cpumask_copy(policy->related_cpus, policy->cpus);
> -		/* Clear mask of registered CPUs */
> -		cpumask_clear(policy->real_cpus);
>  	}
>  
>  	/*

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

PATCH] cpufreq: Do not clear real_cpus mask on policy init "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-02-13 13:50 +0100
  Re: PATCH] cpufreq: Do not clear real_cpus mask on policy init Viresh Kumar <viresh.kumar@linaro.org> - 2017-02-14 04:50 +0100

csiph-web