Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580211
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v5 11/15] livepatch: use kstrtobool() in enabled_store() |
| Date | 2017-02-14 02:50 +0100 |
| Message-ID | <taApJ-3o3-47@gated-at.bofh.it> (permalink) |
| References | <taApH-3o3-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The sysfs enabled value is a boolean, so kstrtobool() is a better fit
for parsing the input string since it does the range checking for us.
Suggested-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Petr Mladek <pmladek@suse.com>
---
kernel/livepatch/core.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 6a137e1..83c4949 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -408,26 +408,23 @@ static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr,
{
struct klp_patch *patch;
int ret;
- unsigned long val;
+ bool enabled;
- ret = kstrtoul(buf, 10, &val);
+ ret = kstrtobool(buf, &enabled);
if (ret)
- return -EINVAL;
-
- if (val > 1)
- return -EINVAL;
+ return ret;
patch = container_of(kobj, struct klp_patch, kobj);
mutex_lock(&klp_mutex);
- if (patch->enabled == val) {
+ if (patch->enabled == enabled) {
/* already in requested state */
ret = -EINVAL;
goto err;
}
- if (val) {
+ if (enabled) {
ret = __klp_enable_patch(patch);
if (ret)
goto err;
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 00/15] livepatch: hybrid consistency model Josh Poimboeuf <jpoimboe@redhat.com> - 2017-02-14 02:50 +0100
[PATCH v5 11/15] livepatch: use kstrtobool() in enabled_store() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-02-14 02:50 +0100
[PATCH v5 07/15] livepatch/s390: add TIF_PATCH_PENDING thread flag Josh Poimboeuf <jpoimboe@redhat.com> - 2017-02-14 02:50 +0100
[PATCH v5 01/15] stacktrace/x86: add function for detecting reliable stack traces Josh Poimboeuf <jpoimboe@redhat.com> - 2017-02-14 02:50 +0100
Re: [PATCH v5 01/15] stacktrace/x86: add function for detecting reliable stack traces Miroslav Benes <mbenes@suse.cz> - 2017-02-15 13:20 +0100
Re: [PATCH v5 01/15] stacktrace/x86: add function for detecting reliable stack traces Josh Poimboeuf <jpoimboe@redhat.com> - 2017-02-15 15:50 +0100
Re: [PATCH v5 13/15] livepatch: change to a per-task consistency model Miroslav Benes <mbenes@suse.cz> - 2017-02-16 15:40 +0100
Re: [PATCH v5 13/15] livepatch: change to a per-task consistency model Josh Poimboeuf <jpoimboe@redhat.com> - 2017-02-16 21:40 +0100
Re: [PATCH v5 13/15] livepatch: change to a per-task consistency model Miroslav Benes <mbenes@suse.cz> - 2017-02-17 10:00 +0100
Re: [PATCH v5 13/15] livepatch: change to a per-task consistency model Josh Poimboeuf <jpoimboe@redhat.com> - 2017-02-21 22:30 +0100
Re: [PATCH v5 13/15] livepatch: change to a per-task consistency model Miroslav Benes <mbenes@suse.cz> - 2017-02-22 10:10 +0100
Re: [PATCH v5 00/15] livepatch: hybrid consistency model Miroslav Benes <mbenes@suse.cz> - 2017-02-17 10:00 +0100
csiph-web