Re: [PATCH v3] softirq: Prevent looping on disabled tasklets

From	Chris Wilson <chris@chris-wilson.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] softirq: Prevent looping on disabled tasklets
Date	2017-02-12 17:10 +0100
Message-ID	<ta4SS-8qq-9@gated-at.bofh.it> (permalink)
References	<ta30K-7i0-9@gated-at.bofh.it> <ta4zw-84o-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Feb 12, 2017 at 03:46:09PM +0000, Chris Wilson wrote:
> +void tasklet_enable(struct tasklet_struct *t)
> +{
> +	if (!atomic_dec_and_test(&t->count))
> +		return;
> +
> +	if (test_bit(TASKLET_STATE_SCHED, &t->state))
> +		raise_softirq(HI_SOFTIRQ | TASKLET_SOFTIRQ);

And of course this can't work as raise_softirq() is local to the cpu.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] softirq: Prevent looping on disabled tasklets Chris Wilson <chris@chris-wilson.co.uk> - 2017-02-12 15:10 +0100
  Re: [PATCH] softirq: Prevent looping on disabled tasklets Chris Wilson <chris@chris-wilson.co.uk> - 2017-02-12 15:30 +0100
  [PATCH v2] softirq: Prevent looping on disabled tasklets Chris Wilson <chris@chris-wilson.co.uk> - 2017-02-12 15:40 +0100
  Re: [Intel-gfx] [PATCH] softirq: Prevent looping on disabled tasklets kbuild test robot <lkp@intel.com> - 2017-02-12 16:10 +0100
  [PATCH v3] softirq: Prevent looping on disabled tasklets Chris Wilson <chris@chris-wilson.co.uk> - 2017-02-12 16:50 +0100
    Re: [PATCH v3] softirq: Prevent looping on disabled tasklets Chris Wilson <chris@chris-wilson.co.uk> - 2017-02-12 17:10 +0100

csiph-web