Re: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared
Date	Sun, 12 Feb 2017 12:00:02 +0100
Message-ID	<ta02S-5ge-1@gated-at.bofh.it> (permalink)
References	<t9W8W-2TD-7@gated-at.bofh.it> <t9W8W-2TD-5@gated-at.bofh.it>
User-Agent	Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org
X-Original-Date	Sun, 12 Feb 2017 11:57:11 +0100 (CET)
X-Original-Message-ID	<alpine.DEB.2.20.1702121146370.3734@nanos>
X-Original-References	<1486881870-2490-1-git-send-email-me@tobin.cc> <1486881870-2490-2-git-send-email-me@tobin.cc>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1579191

Show key headers only | View raw

On Sun, 12 Feb 2017, Tobin C. Harding wrote:

A few nitpicks.

> Subject: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared

arch/x86: is not the correct prefix. Run git log on a file to figure out
what the usual prefix is. The file was checked in with 'purgatory', but I'd
prefer 'x86/purgatory' for future changes.

> This patch adds static declaration to a number of variables. Fixes
> sparse symbol was not declared warnings.

Please read 'Documentation...SubmittingPatches' and look for 'This patch'.

I give you an example for a changelog:

  Sparse emits several 'symbol not declared' warnings.

  Make the variables and functions, which have only file scope static.

Now try to map that to the advise in Documentation.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] arch/x86: Fix sparse warning symbol not declared "Tobin C. Harding" <me@tobin.cc> - 2017-02-12 07:50 +0100
  Re: [PATCH 1/2] arch/x86: Fix sparse warning symbol not declared Thomas Gleixner <tglx@linutronix.de> - 2017-02-12 12:00 +0100

csiph-web