Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1681056

[PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning

From Lynn Lei <lynnl.yet@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison warning
Date 2017-07-04 17:30 +0200
Message-ID <tZxW2-1JA-31@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Fixed a constant-left comparison warning issue check by
scripts/checkpatch.pl:
  WARNING: Comparisons should place the constant on the right side of the test

Signed-off-by: Lynn Lei <lynnl.wit@gmail.com>
---
 drivers/video/fbdev/sm712fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sm712fb.c b/drivers/video/fbdev/sm712fb.c
index 172e94146878..502d0de2feec 100644
--- a/drivers/video/fbdev/sm712fb.c
+++ b/drivers/video/fbdev/sm712fb.c
@@ -1478,7 +1478,7 @@ static int smtcfb_pci_probe(struct pci_dev *pdev,
 	}
 
 	/* can support 32 bpp */
-	if (15 == sfb->fb->var.bits_per_pixel)
+	if (sfb->fb->var.bits_per_pixel == 15)
 		sfb->fb->var.bits_per_pixel = 16;
 
 	sfb->fb->var.xres_virtual = sfb->fb->var.xres;
-- 
2.13.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 4/4] video: fbdev: sm712fb.c: fixed constant-left comparison  warning Lynn Lei <lynnl.yet@gmail.com> - 2017-07-04 17:30 +0200

csiph-web