Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32
Date	2017-07-04 16:10 +0200
Message-ID	<tZwGC-Oa-31@gated-at.bofh.it> (permalink)
References	(1 earlier) <tXSrT-6F8-11@gated-at.bofh.it> <tXZMJ-39Q-13@gated-at.bofh.it> <tY066-3v8-3@gated-at.bofh.it> <tY1Ox-4rm-7@gated-at.bofh.it> <tYV4l-88R-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> >> Frankly, I am not a big fan of converting board files if we cannot test
> >> the changes.
> > 
> > So, if no one is using that old boards, should we really take care
> > more than just compile test?
> > 
> > P.S. Legacy platform data makes a burden of development nowadays.
> > Built-in device properties API (as a part of Unified Device
> > Properties) is exactly for getting rid of legacy stuff and make things
> > much cleaner.
> 
> We could probably go with an approach of making the device properties 
> the default which would suit the new style and leave the platform_data 
> to override things if it is present.
> 
> If/when the older platforms go away we can drop struct 
> i2c_pca9564_pf_platform_data.

I don't have a super strong opinion, so we can discuss this for 4.14.
For 4.13, I picked the two easy patches already. Thanks!

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32 Wolfram Sang <wsa@the-dreams.de> - 2017-07-04 16:10 +0200

csiph-web