Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata

From	Pali Rohár <pali.rohar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata
Date	2017-07-04 15:30 +0200
Message-ID	<tZw3V-il-27@gated-at.bofh.it> (permalink)
References	<tPdcd-3gP-5@gated-at.bofh.it> <tPjB0-7ik-19@gated-at.bofh.it> <tPq9s-3eA-11@gated-at.bofh.it> <tPtK2-5mC-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday 06 June 2017 22:50:52 Pali Rohár wrote:
> On Tuesday 06 June 2017 19:02:01 Darren Hart wrote:
> > On Tue, Jun 06, 2017 at 12:04:40PM +0200, Pali Rohár wrote:
> > > On Monday 05 June 2017 20:16:44 Andy Lutomirski wrote:
> > > > +#define WMI_BMOF_GUID "05901221-D566-11D1-B2F0-00A0C9062910"
> > > > +MODULE_ALIAS("wmi:" WMI_BMOF_GUID);
> > > 
> > > Cannot we generate MODULE_ALIAS from module_wmi_driver()? IIRC it
> > > is working for i2c drivers.
> > 
> > I could see this being automated since we always use wmi:GUID, but it
> > isn't currently. Happy to consider it as a follow on.
> > 
> > Do you have a specific i2c example you think we should consider
> > following?
> 
> For i2c you can specify in driver code:
> 
> MODULE_DEVICE_TABLE(i2c, id_table);
> 
> And it automatically provides (via file.mod.c) all needed MODULE_ALIAS.
> 
> So when we have wmi_bmof_id_table in driver, cannot we use this?
> 
> MODULE_DEVICE_TABLE(wmi, wmi_bmof_id_table);

Just reminder for above idea ↑↑↑

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded  Binary WMI MOF metadata Pali Rohár <pali.rohar@gmail.com> - 2017-07-04 15:30 +0200

csiph-web