Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1680860

Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

Show all headers | View raw

2017-07-04 19:06 GMT+09:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Tue, 2017-07-04 at 12:53 +0900, Masahiro Yamada wrote:
>> Some of include directives in include/linux/gpio/driver.h are
>> unneeded because the header does not need to know the content of
>> struct device, irq_chip, etc.  Just declare they are structures.
>>
>> On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
>> turned out to be necessary for irq_flow_handler_t and spinlock_t,
>> respectively.
>>
>> Each driver should include what it needs without relying on what is
>> implicitly included from <linux/gpio/driver.h>.  This will cut down
>> unnecessary header parsing.
>
> If Linus is okay with the following proposal I would rather go with it,
> i.e. logical split the series to
>
> 1. Fix IRQ related headers inclusion
> 2. Fix pinconf-generic.h inclusion
> 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?)

Maybe
  4.  Fix (platform_)device inclusion


But, I do not see much sense to touch headers multiple times.



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-04 06:00 +0200
  Re: [PATCH] gpio: drop unnecessary includes from  include/linux/gpio/driver.h Charles Keepax <ckeepax@opensource.cirrus.com> - 2017-07-04 10:40 +0200
  Re: [PATCH] gpio: drop unnecessary includes from  include/linux/gpio/driver.h Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-07-04 12:10 +0200
    Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-04 12:50 +0200
  Re: [PATCH] gpio: drop unnecessary includes from  include/linux/gpio/driver.h William Breathitt Gray <vilhelm.gray@gmail.com> - 2017-07-04 15:00 +0200
    Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-04 17:50 +0200
      Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-04 18:00 +0200

csiph-web