Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1680839
| From | Lin Yun Sheng <linyunsheng@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH net 2/3] net: hns: Fix a wrong op phy C45 code |
| Date | 2017-07-04 12:20 +0200 |
| Message-ID | <tZt61-6UJ-15@gated-at.bofh.it> (permalink) |
| References | <tZt61-6UJ-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Yunsheng Lin <linyunsheng@huawei.com> As the user manual described, the second step to write to C45 phy by mdio should be data, but not address. Here we should fix this issue. Signed-off-by: Yankejian <yankejian@huawei.com> Reviewed-by: lipeng <lipeng321@huawei.com> Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com> --- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index e5221d9..017e084 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -261,7 +261,7 @@ static int hns_mdio_write(struct mii_bus *bus, /* config the data needed writing */ cmd_reg_cfg = devad; - op = MDIO_C45_WRITE_ADDR; + op = MDIO_C45_WRITE_DATA; } MDIO_SET_REG_FIELD(mdio_dev, MDIO_WDATA_REG, MDIO_WDATA_DATA_M, -- 1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net 0/3] Bugfixs for hns ethernet driver Lin Yun Sheng <linyunsheng@huawei.com> - 2017-07-04 12:20 +0200
[PATCH net 3/3] net: hns: Fix a skb used after free bug Lin Yun Sheng <linyunsheng@huawei.com> - 2017-07-04 12:20 +0200
[PATCH net 2/3] net: hns: Fix a wrong op phy C45 code Lin Yun Sheng <linyunsheng@huawei.com> - 2017-07-04 12:20 +0200
Re: [PATCH net 0/3] Bugfixs for hns ethernet driver Florian Fainelli <f.fainelli@gmail.com> - 2017-07-04 19:00 +0200
Re: [PATCH net 0/3] Bugfixs for hns ethernet driver Yunsheng Lin <linyunsheng@huawei.com> - 2017-07-05 10:40 +0200
csiph-web